add partial share ownership support (float)... and penny rounding errors.

accountProviders.go

@@ -1,10 +1,10 @@
 package main
 
 import (
-	"deadbeef.codes/steven/ynab-portfolio-monitor/providers/bitcoin"
+	"code.stevenpolley.net/steven/ynab-portfolio-monitor/providers/bitcoin"
-	"deadbeef.codes/steven/ynab-portfolio-monitor/providers/questrade"
+	"code.stevenpolley.net/steven/ynab-portfolio-monitor/providers/questrade"
-	"deadbeef.codes/steven/ynab-portfolio-monitor/providers/staticjsonFinnhub"
+	"code.stevenpolley.net/steven/ynab-portfolio-monitor/providers/staticjsonFinnhub"
-	"deadbeef.codes/steven/ynab-portfolio-monitor/providers/staticjsonYahooFinance"
+	"code.stevenpolley.net/steven/ynab-portfolio-monitor/providers/staticjsonYahooFinance"
 )
 
 // AccountProvider is the base set of requirements to be implemented for any integration

go.mod

@@ -1,4 +1,4 @@
-module deadbeef.codes/steven/ynab-portfolio-monitor
+module code.stevenpolley.net/steven/ynab-portfolio-monitor
 
 go 1.22
 

main.go

@@ -7,7 +7,7 @@ import (
 	"text/template"
 	"time"
 
-	"deadbeef.codes/steven/ynab-portfolio-monitor/ynab"
+	"code.stevenpolley.net/steven/ynab-portfolio-monitor/ynab"
 )
 
 var (

providers/bitcoin/providerImpl.go

@@ -55,14 +55,19 @@ func (p *Provider) GetBalances() ([]int, []string, error) {
 			defer wg.Done()
 			addressResponse, err := p.client.getAddress(bitcoinAddress)
 			if err != nil {
-				err := fmt.Errorf("failed to get bitcoin address '%s': %v", bitcoinAddress, err)
+				err := fmt.Errorf("failed to get BTC balance for bitcoin address '%s': %v", bitcoinAddress, err)
-				goErr = &err
+				if err != nil {
+					goErr = &err
+				}
 				return
 			}
 			satoshiBalance += addressResponse.ChainStats.FundedTxoSum - addressResponse.ChainStats.SpentTxoSum
 		}(goErr)
 	}
 	wg.Wait()
+	if goErr != nil {
+		return nil, nil, *goErr
+	}
 
 	fiatBalance, err := p.client.convertBTCToCAD(satoshiBalance)
 	if err != nil {

providers/staticjsonYahooFinance/cache.go

@@ -0,0 +1,15 @@
+package staticjsonYahooFinance
+
+import (
+	"time"
+)
+
+const cacheAgeSeconds = 900
+
+// intialized in providerImpl.go's Configure
+var chartCache map[string]chartCacheEntry
+
+type chartCacheEntry struct {
+	Chart       chartResponse
+	LastUpdated time.Time
+}

providers/staticjsonYahooFinance/chart.go

@@ -3,10 +3,11 @@ package staticjsonYahooFinance
 import (
 	"fmt"
 	"net/url"
+	"time"
 )
 
-// A chart response is what we get back from Yahoo Finance
+// A chartResponse response is what we get back from Yahoo Finance
-type chart struct {
+type chartResponse struct {
 	Chart struct {
 		Result []struct {
 			Meta struct {
@@ -69,8 +70,16 @@ type chart struct {
 	} `json:"chart"`
 }
 
+// getChart first checks if the symbol chartCacheEntry is valid,
+// and if not then it downloads fresh chart data
 func (c client) getChart(symbol string) (int, error) {
-	chartResponse := &chart{}
+	if cacheItem, ok := chartCache[symbol]; ok {
+		// if the cacheEntry is still valid, use it
+		if time.Now().Before(cacheItem.LastUpdated.Add(cacheAgeSeconds)) {
+			return int(cacheItem.Chart.Chart.Result[0].Meta.RegularMarketPrice * 1000), nil
+		}
+	}
+	chartResponse := &chartResponse{}
 	err := c.get(fmt.Sprintf("/chart/%s", symbol), chartResponse, url.Values{})
 	if err != nil {
 		return 0, fmt.Errorf("http get request error: %v", err)
@@ -80,5 +89,7 @@ func (c client) getChart(symbol string) (int, error) {
 		return 0, fmt.Errorf("unexpected length of results - expected 1 but got %d", len(chartResponse.Chart.Result))
 	}
 
+	chartCache[symbol] = chartCacheEntry{Chart: *chartResponse, LastUpdated: time.Now()}
+
 	return int(chartResponse.Chart.Result[0].Meta.RegularMarketPrice * 1000), nil
 }

providers/staticjsonYahooFinance/client.go

@@ -9,7 +9,7 @@ import (
 	"time"
 )
 
-const apiBaseURL = "https://query1.finance.yahoo.com/v8/finance/"
+const apiBaseURL = "https://query1.finance.yahoo.com/v8/finance"
 
 // A client is the structure that will be used to consume the API
 // endpoints. It holds the login credentials, http client/transport,
@@ -26,6 +26,9 @@ func (c *client) get(endpoint string, out interface{}, query url.Values) error {
 		return err
 	}
 
+	// Yahoo finance requires user agent string now?
+	req.Header.Set("User-Agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:138.0) Gecko/20100101 Firefox/138.0")
+
 	res, err := c.httpClient.Do(req)
 	if err != nil {
 		return fmt.Errorf("http get request failed: %v", err)
@@ -50,7 +53,7 @@ func (c *client) processResponse(res *http.Response, out interface{}) error {
 	}
 
 	if res.StatusCode != 200 {
-		return fmt.Errorf("got http response status '%d' but expected 200", res.StatusCode)
+		return fmt.Errorf("got http response status '%d' but expected 200 for request at URL '%s'", res.StatusCode, res.Request.URL)
 	}
 
 	err = json.Unmarshal(body, out)

providers/staticjsonYahooFinance/providerImpl.go

@@ -9,8 +9,8 @@ import (
 )
 
 type security struct {
-	Symbol   string `json:"symbol"`
+	Symbol   string  `json:"symbol"`
-	Quantity int    `json:"quantity"`
+	Quantity float64 `json:"quantity"`
 }
 
 type account struct {
@@ -47,6 +47,8 @@ func (p *Provider) Configure() error {
 		return fmt.Errorf("failed to create new client: %v", err)
 	}
 
+	chartCache = make(map[string]chartCacheEntry)
+
 	return nil
 }
 
@@ -61,7 +63,7 @@ func (p *Provider) GetBalances() ([]int, []string, error) {
 			if err != nil {
 				return balances, ynabAccountIDs, fmt.Errorf("failed to get quote for security with symbol '%s': %v", p.data.Accounts[i].Securities[j].Symbol, err)
 			}
-			balance += price * p.data.Accounts[i].Securities[j].Quantity
+			balance += int(float64(price) * p.data.Accounts[i].Securities[j].Quantity)
 		}
 		balances = append(balances, balance)
 		ynabAccountIDs = append(ynabAccountIDs, p.data.Accounts[i].YnabAccountID)