main.go

@@ -36,7 +36,7 @@ type ROMCache struct {
 const (
 	romDirectory      = "public" // directory where ROMs are available for download
 	buildOutDirectory = "out"    // directory from build system containing artifacts which we can move to romDirectory
-	cacheFile         = "public/romcache.json" // persistence between server restarts so we don't have to rehash all the ROM files each time the program starts
+	cacheFile         = "public/romcache.json"
 )
 
 var ( // evil global variable
@@ -67,7 +67,7 @@ func init() {
 		log.Printf("loaded cached file: %s", rom.Filename)
 	}
 
-	// Check if any new build artifacts and load any new files into the romCache
+	// Check if any new build artifacts and preload the romCache
 	moveBuildArtifacts()
 	go updateROMCache()
 }
@@ -106,7 +106,7 @@ func updateROMCache() {
 
 	for i, v := range files {
 
-		isLineageROM, splitName := parseROMFileName(v)
+		isLineageROM, splitName := isLineageROMZip(v)
 		if !isLineageROM {
 			continue
 		}
@@ -179,11 +179,9 @@ func updateROMCache() {
 }
 
 // http - GET /
-// The LineageOS updater app needs a JSON array of type LineageOSROM
-// Marshal's romCache.ROMs to JSON to serve as the response body
-
+// Writes JSON response for the updater app to know what versions are available to download
 func lineageOSROMListHandler(w http.ResponseWriter, r *http.Request) {
-	go func() { // Also checks for new builds - TBD need a better method as the first request will return no new updates.  inotify?
+	go func() {
 		newBuilds := moveBuildArtifacts()
 		if newBuilds {
 			updateROMCache()

processFiles.go

@@ -30,7 +30,7 @@ func moveBuildArtifacts() bool {
 	var newROMs bool
 
 	for _, v := range files {
-		if isLineageROM, _ := parseROMFileName(v); !isLineageROM { // skip files that aren't LineageOS ROMs
+		if isLineageROM, _ := isLineageROMZip(v); !isLineageROM { // skip files that aren't LineageOS ROMs
 			continue
 		}
 
@@ -61,14 +61,14 @@ func hashFile(filename string) (string, error) {
 		return "", fmt.Errorf("failed to copy data from file to hash function: %v", err)
 	}
 
-	return string(h.Sum(nil)), nil
+	return fmt.Sprintf("%x", h.Sum(nil)), nil
 }
 
 // false if a file is not a LineageOS ROM .zip file
 // no formal validation is performed - only file naming convention is checked
 // also returns a lineage ROM's filename sliced and delimited by -'s
 // Example filename: lineage-20.0-20230604-UNOFFICIAL-sunfish.zip
-func parseROMFileName(v fs.DirEntry) (bool, []string) {
+func isLineageROMZip(v fs.DirEntry) (bool, []string) {
 
 	// skip directories, non .zip files and files that don't begin with lineage-
 	if v.Type().IsDir() || !strings.HasSuffix(v.Name(), ".zip") || !strings.HasPrefix(v.Name(), "lineage-") {